Accept file objects #99
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For functions that work on UBI files and call `open()`, additionally allow a file object to be passed, and in that case leave the responsibility of closing it to the caller. This means that the scripts can now open the file once instead of two to four times previously.
Contributor
|
This looks decent but I'll wait for my more Python experienced colleagues to have a look :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more flexibility when using ubireader as a library and fixes the behavior mentioned in #89 (comment).
For example this is now possible:
Admittedly this is not the best use case right now if you need
walk.index()because it takes an extremely long time when the file is zipped, but that's a separate issue.