Skip to content

Improve fork integration and liveness check tests #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jribbink merged 2 commits into from
Dec 21, 2025
Merged

Improve fork integration and liveness check tests #935

jribbink merged 2 commits into from
Dec 21, 2025

Conversation

@turbolent
Copy link
Member

@turbolent turbolent commented Dec 19, 2025

Description

Use testify, parallelize, refactor repeated constants, etc.

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@turbolent
improve fork integration and liveness check tests
9356015 
use testify, parallelize, refactor repeated constants, etc.
@turbolent turbolent self-assigned this Dec 19, 2025
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Dec 19, 2025
@github-actions
Copy link

github-actions bot commented Dec 19, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

jribbink
jribbink approved these changes Dec 20, 2025
View reviewed changes
Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jribbink jribbink enabled auto-merge (squash) December 21, 2025 22:20
@jribbink jribbink merged commit 33d4e00 into master Dec 21, 2025
7 checks passed
@jribbink jribbink deleted the bastian/improve-tests branch December 21, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jribbink jribbink jribbink approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@peterargue peterargue Awaiting requested review from peterargue peterargue is a code owner

@mfbz mfbz Awaiting requested review from mfbz mfbz is a code owner

Assignees

@turbolent turbolent

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turbolent @jribbink