added getInvetory retriever method fixes #30#32
Open
bjartek wants to merge 3 commits intoonflow:mainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bshahid331
reviewed
Jul 15, 2022
cadence/contracts/NFTRetrieval.cdc
Outdated
| let types = NFTCatalog.getCatalogTypeData() | ||
| for nftType in types.keys { | ||
| let typeData=types[nftType]! | ||
| let collectionKey=typeData.keys[0] |
Contributor
There was a problem hiding this comment.
Why 0 index here? Do we want to handle the case if one nft type has multiple collections like Mint Store?
Author
There was a problem hiding this comment.
All the collections are stored in the same path, we just want the ids of them all. Paritioning these into subcollections will take up a lot of gas since you need to borrow each one.
bshahid331
reviewed
Jul 15, 2022
cadence/contracts/NFTRetrieval.cdc
Outdated
| let collectionKey=typeData.keys[0] | ||
| let catalogEntry = NFTCatalog.getCatalogEntry(collectionIdentifier:collectionKey)! | ||
| let path =catalogEntry.collectionData.publicPath | ||
| let cap= account.getCapability<&{MetadataViews.ResolverCollection}>(path) |
Contributor
There was a problem hiding this comment.
This won't be guaranteed to exist just a heads up
Author
There was a problem hiding this comment.
What will not be guaranteed to not exist? I check if the cap is linked on the next line.
Contributor
There was a problem hiding this comment.
The capability is linked
cadence/contracts/NFTRetrieval.cdc
Outdated
| let types = NFTCatalog.getCatalogTypeData() | ||
| for nftType in types.keys { | ||
| let typeData=types[nftType]! | ||
| let collectionKey=typeData.keys[0] |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.