Skip to content

Comments

Restartable errors#35

Merged
lbradstreet merged 5 commits intoonyx-platform:0.9.xfrom
icxmedia:restartable-errors
Mar 13, 2019
Merged

Restartable errors#35
lbradstreet merged 5 commits intoonyx-platform:0.9.xfrom
icxmedia:restartable-errors

Conversation

@djjolicoeur
Copy link

@djjolicoeur djjolicoeur commented Mar 13, 2019

We have an application still running on 0.9.x and our transactor occasionally fails over. As is, this kills the job if we are in the middle of a tx. I forked the existing PR that handles a similar situation, however it would not handle the exception thrown in the case of a transactor failing over. In addition, datomic allows you to specify a transaction timeout via a property, i.e. -Ddatomic.txTimeoutMsec=15000, which throws an exception we can catch and handle in the plugin, but doesn't hard code the value in the plugin itself.

We have started moving our existing jobs to 0.14 and I would like to do something similar in that version of the plugin, as well.

@lbradstreet
Copy link
Member

I'll merge this into 0.9.x, though 0.9.x is not supported any more. We should get a similar PR into master when you're ready.

Cheers

@lbradstreet lbradstreet merged commit 957744f into onyx-platform:0.9.x Mar 13, 2019
@djjolicoeur
Copy link
Author

@lbradstreet, we are actually in the process of moving everything to 0.14, but we have some custom plugin work to do before we get there. I imagine I will be bugging you about the 0.14 version of this in the near future!

Are you going to cut a release without the -SNAPSHOT, or should I push a release clojars under a different org name and pull it in that way? i.e. `com.icxmedia/onyx-datomic "0.9.12.2". I haven't tried just cutting a release as-is sans SNAPSHOT, but I assume that will not work and wouldn't want to do it without checking.

Thanks for onyx and the many times you have helped me out!
Dan J

@lbradstreet
Copy link
Member

lbradstreet commented Mar 14, 2019 via email

@lbradstreet
Copy link
Member

lbradstreet commented Mar 14, 2019 via email

@djjolicoeur
Copy link
Author

thanks, @lbradstreet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants