Corrects errors in 0.9.15.2 tasks restarting on tx timeouts/unavailable#36
Open
djjolicoeur wants to merge 6 commits intoonyx-platform:0.9.xfrom
Open
Corrects errors in 0.9.15.2 tasks restarting on tx timeouts/unavailable#36djjolicoeur wants to merge 6 commits intoonyx-platform:0.9.xfrom
djjolicoeur wants to merge 6 commits intoonyx-platform:0.9.xfrom
Conversation
Author
|
@lbradstreet was wondering if you had a chance to look at this yet? If it's going to be a while, I can deploy a jar from out fork under our Still working on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lbradstreet it looks like I missed a few things in the 0.9.15.2 branch that prevented the tasks from being restarted. I honestly wasn't expecting for it to be merged straight away!!
in this branch:
write-batchimplementation for each output and make sure the restart code is working properly, given the appropriate exceptions and behaves as it did before, otherwise.Sorry for taking up your time with an unsupported branch, but if you could cut a release, it would be helpful to us as we transition to 0.14.x.
Speaking of, for 0.14.x, I am going to add something to the information model to make this restartable behavior optional, I think. I can imagine some folks might not want to reboot the task on those conditions. I have started working on that branch already and, hopefully, will have that to you soon.