Merged
Conversation
Completes Phase 1 SSH migration following the pattern established in PR #13. ## Changes - `lib/ssh-utils.bash`: SSH utilities with key detection, config management, agent operations - `bin/install/ssh.bash`: Complete bash replacement for ssh.zsh installation script - `test/install/test-ssh-utils.bats`: 14 comprehensive unit tests for utilities - `test/install/test-ssh-installation.bats`: 7 integration tests for complete workflow ## Key Improvements - shellcheck compliance with zero warnings - Better macOS version detection for ssh-add keychain flag - Comprehensive test coverage (21 total tests) - Cleaner separation of concerns with utility functions - More robust error handling This continues the bash migration effort and demonstrates the pattern can be successfully applied to different installation scripts.
Updates the bash migration epic to reflect PR #15 creation and current Phase 1 status. ## Documentation Updates - Added PR #15 SSH Installation Testing details - Updated current status: 2 of 3 core scripts migrated - Adjusted Phase 1 title to reflect it's still in progress - Listed Homebrew as next migration target after CI update Maintains accurate project roadmap showing SSH migration is complete and ready for review.
ooloth
added a commit
that referenced
this pull request
Jul 10, 2025
- Preserve enhanced architectural planning from local changes - Include SSH migration progress (PR #15) from upstream - Maintain three-tier architecture approach and setup.bash strategy
ooloth
added a commit
that referenced
this pull request
Jul 10, 2025
- Preserve enhanced three-tier architecture approach - Include current SSH migration status (PR #15) - Maintain setup.bash-centered strategy and shared utility extraction plans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💪 What
Complete bash migration of SSH installation script with comprehensive testing infrastructure. Creates
lib/ssh-utils.bash,bin/install/ssh.bash, and full test suites replacing the original zsh implementation.Also includes:
🤔 Why
Continues Phase 1 of the bash migration following the successful pattern from PR #13 (GitHub installation). Provides better tooling support, industry-standard testing with bats, and improved maintainability. Sets foundation for enhanced architecture with setup.bash integration and shared utility extraction.
👀 Usage
👩🔬 How to validate
bats test/install/test-ssh-*.bats(21 total tests)shellcheck bin/install/ssh.bash lib/ssh-utils.bash(clean output)bin/install/ssh.zshvsbin/install/ssh.bash.claude/tasks/2025-07-07-bash-migration.md🔗 Related links