Skip to content

feat: Make defaultVariant and value optional #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 7 commits into from
Mar 4, 2026
Merged

feat: Make defaultVariant and value optional #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b280ddb
feat: Make defaultVariant and value optional
marcozabel Jan 29, 2026
0e92e8b
fix: readd code default values
marcozabel Feb 2, 2026
605fbb0
fix: variable name
marcozabel Feb 2, 2026
eef4ec9
fix: add previous no-default test stage
marcozabel Feb 4, 2026
119f9f6
fix: test suite name
marcozabel Feb 4, 2026
8a919e5
chore: add deprecation notice
marcozabel Feb 4, 2026
9384c07
fixup: update flagd
toddbaert Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion flagd/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG FLAGD_BASE_IMAGE=ghcr.io/open-feature/flagd:v0.12.9
ARG FLAGD_BASE_IMAGE=ghcr.io/open-feature/flagd:v0.14.0
ARG TARGETARCH

FROM ${FLAGD_BASE_IMAGE} AS flagd
Expand Down
21 changes: 20 additions & 1 deletion gherkin/evaluation.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ Feature: flagd evaluations
| integer-targeted-zero-flag | Integer | 1 | 0 |
| float-targeted-zero-flag | Float | 0.1 | 0.0 |

@no-default
# This suite is deprecated and @no-default-variant should be used instead
@no-default @deprecated
Scenario Outline: Resolves flag with no defaultValue correctly
Given a <type>-flag with key "<key>" and a default value "<default>"
And a context containing a key "email", with type "String" and with value "<email>"
Expand All @@ -84,3 +85,21 @@ Feature: flagd evaluations
| no-default-flag-null-targeting-variant | String | wozniak@orange.com | Founder | Founder | ERROR | FLAG_NOT_FOUND |
| no-default-flag-null-targeting-variant | String | jobs@orange.com | CEO | CEO | TARGETING_MATCH | |
| no-default-flag-undefined-targeting-variant | String | wozniak@orange.com | Retired | Retired | ERROR | FLAG_NOT_FOUND |

@no-default-variant
Scenario Outline: Resolves flag with no default variant correctly
Given a <type>-flag with key "<key>" and a default value "<code_default>"
And a context containing a key "email", with type "String" and with value "<email>"
When the flag was evaluated with details
Then the resolved details value should be "<resolved_value>"
And the reason should be "<reason>"

Examples:
| key | type | email | code_default | resolved_value | reason |
| null-default-flag | Boolean | | true | true | DEFAULT |
| null-default-flag | Boolean | | false | false | DEFAULT |
| undefined-default-flag | Integer | | 100 | 100 | DEFAULT |
| no-default-flag-null-targeting-variant | String | wozniak@orange.com | Inventor | Inventor | DEFAULT |
| no-default-flag-null-targeting-variant | String | wozniak@orange.com | Founder | Founder | DEFAULT |
| no-default-flag-null-targeting-variant | String | jobs@orange.com | CEO | CEO | TARGETING_MATCH |
| no-default-flag-undefined-targeting-variant | String | wozniak@orange.com | Retired | Retired | DEFAULT |
Loading