feat!: make default variant optional

[toddbaert]

replaying #331

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the flagd base image to its latest version, v0.14.0, to incorporate recent improvements and features. Alongside this update, the test suite has been enhanced to include comprehensive validation for flag evaluations where the default variant is optional, ensuring robust behavior and correct resolution in such configurations.

Highlights

• Dependency Update: Upgraded the flagd base image in the Dockerfile from version v0.12.9 to v0.14.0.
• Test Suite Enhancement: Introduced a new Gherkin scenario outline, @no-default-variant, to specifically test flag resolution when a default variant is not explicitly provided.
• Test Deprecation: Marked the existing @no-default Gherkin scenario as deprecated, advising the use of the new @no-default-variant scenario instead.

Changelog

• flagd/Dockerfile
  • Updated FLAGD_BASE_IMAGE argument from ghcr.io/open-feature/flagd:v0.12.9 to ghcr.io/open-feature/flagd:v0.14.0.
• gherkin/evaluation.feature
  • Added a comment and @deprecated tag to the @no-default scenario, indicating its deprecation in favor of @no-default-variant.
  • Introduced a new scenario outline Resolves flag with no default variant correctly with a set of examples to test various cases of optional default variants.

Activity

• This pull request is a re-submission of a previous pull request, specifically https://github.com/open-feature/flagd-testbed/pull/331.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the flagd base image to v0.14.0 and adjusts the Gherkin evaluation tests to reflect a breaking change: making the defaultVariant optional. No security vulnerabilities were found. The changes are logical and well-tested, correctly validating that when a defaultVariant is not specified, the evaluation now falls back to the SDK-provided default value with a DEFAULT reason. There is one minor suggestion to improve the clarity of one of the new test cases.

[gemini-code-assist]

For this test case, the code_default and resolved_value are identical even though the resolution reason is TARGETING_MATCH. This can be confusing. To make it clear that the code_default is ignored when targeting matches, consider using a different value for code_default, for example "fallback".

| no-default-flag-null-targeting-variant      | String  | jobs@orange.com    | fallback      | CEO            | TARGETING_MATCH |