Skip to content

Conversation

@justincampbell
Copy link
Member

Summary

  • Add make install target that delegates to go install ./cmd/pomodoro
  • Update README with make install option for local development
  • Follows standard Go CLI project conventions for installation

Test plan

  • Verify make install works locally
  • Confirm installation docs are clear and accurate
  • Test that installed binary works correctly

🤖 Generated with Claude Code

- Add make install target that delegates to go install ./cmd/pomodoro
- Update README with make install option for local development
- Follows standard Go CLI project conventions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings September 26, 2025 13:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a convenient make install target for local development and updates the installation documentation to include this new option. The changes follow standard Go CLI project conventions by providing a simple way to install the binary from a cloned repository.

  • Add make install target that delegates to go install ./cmd/pomodoro
  • Update README with installation instructions for the new make target

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Makefile Adds new install target for installing the binary locally
README.md Updates installation documentation to include the new make install option

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Add Version variable to cmd/pomodoro/main.go that defaults to "dev".
This ensures the version subcommand works when installing via go install,
showing "dev" for development builds and proper version when built with LDFLAGS.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Member Author

@justincampbell justincampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR to fix version info for go install builds. Please re-review the changes.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@justincampbell justincampbell merged commit 555478e into main Sep 26, 2025
2 checks passed
@justincampbell justincampbell deleted the improve-installation branch September 26, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants