Skip to content

Conversation

@Yadunund
Copy link
Member

Fix #80 by implementing select changes from #24

Yadunund added 2 commits July 14, 2021 16:10
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund requested a review from youliangtan July 15, 2021 09:57
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #81 (2e56c91) into main (f4cf7f7) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   22.02%   22.07%   +0.05%     
==========================================
  Files         410      410              
  Lines       32894    32858      -36     
  Branches    16064    16022      -42     
==========================================
+ Hits         7244     7255      +11     
+ Misses      17814    17795      -19     
+ Partials     7836     7808      -28     
Flag Coverage Δ
tests 22.07% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...f_fleet_adapter/services/detail/impl_Negotiate.hpp
...ter/src/rmf_fleet_adapter/agv/test/MockAdapter.cpp
...ter/src/rmf_fleet_adapter/agv/test/MockAdapter.cpp
...2/rmf_fleet_adapter_python/src/planner/planner.cpp
...leet_adapter/src/rmf_fleet_adapter/agv/Adapter.cpp
...ffic_ros2/test/mock_schedule_nodes/wrong_query.cpp
...mf_fleet_adapter/services/detail/impl_FindPath.hpp
...Cpp-4.1.0/Rx/v2/src/rxcpp/operators/rx-finally.hpp
...ter/include/rmf_fleet_adapter/agv/TrafficLight.hpp
...f_fleet_adapter/test/phases/MockAdapterFixture.cpp
... and 810 more

youliangtan
youliangtan previously approved these changes Jul 21, 2021
Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Also tested it, looks fine 👍

Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund enabled auto-merge (squash) July 22, 2021 10:28
@Yadunund Yadunund requested a review from youliangtan July 22, 2021 10:29
@Yadunund Yadunund disabled auto-merge July 22, 2021 10:56
@Yadunund
Copy link
Member Author

Hmm not sure why test_rmf_fleet_adapter is failing after merging in main 🤔

  The following tests FAILED:
  	  2 - test_rmf_fleet_adapter (Failed)
  Errors while running CTest
  Output from these tests are in: /home/runner/work/rmf_ros2/rmf_ros2/ros_ws/build/rmf_fleet_adapter/Testing/Temporary/LastTest.log
  Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
  ---

@mxgrey
Copy link
Contributor

mxgrey commented Jul 22, 2021

According to the test artifacts, a segfault happened in test_RequestLift. I don't see any particular explanation for that, and I haven't seen a crash happen there before. Let's keep a careful eye on that test moving forward, to see if it crashes regularly. For now, let's just rerun the test and not block this PR, since it's almost certainly an unrelated issue.

@Yadunund
Copy link
Member Author

Re-ran the test and it seems to pass this time.

Copy link
Member

@youliangtan youliangtan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Yadunund Yadunund merged commit ef7cd9d into main Jul 23, 2021
@Yadunund Yadunund deleted the fix/task_summary_profile branch July 23, 2021 05:04
arjo129 pushed a commit that referenced this pull request Oct 12, 2021
* Remove unused map

Signed-off-by: Yadunund <yadunund@openrobotics.org>

* Pass map with TaskProfiles when setting TaskManager queue

Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
aaronchongth pushed a commit that referenced this pull request May 6, 2025
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TaskProfile field in TaskSummary not populated

3 participants