Skip to content

Create a sub-folder for mySQL benchmarks#56

Merged
lilith218 merged 13 commits intoopen-s4c:mainfrom
lilith218:lilith/mv-bm-folder
Mar 3, 2026
Merged

Create a sub-folder for mySQL benchmarks#56
lilith218 merged 13 commits intoopen-s4c:mainfrom
lilith218:lilith/mv-bm-folder

Conversation

@lilith218
Copy link
Member

@lilith218 lilith218 commented Mar 3, 2026

Change

  • move all mySQL benchmarks to bench/targets/mysql
  • move all mySQL config files to config/mysql
  • let cmake look recursively for headers and exclude those under sys
    use subdir name as target name prefix
  • let bm-generator generate headers and config under subdir gen-ws
  • reflect changes on related CI jobs and config files

@lilith218 lilith218 force-pushed the lilith/mv-bm-folder branch from 96fe85a to c0a7848 Compare March 3, 2026 11:00
@lilith218 lilith218 changed the title Lilith/mv bm folder Create a sub-folder for mySQL benchmarks Mar 3, 2026
@lilith218 lilith218 marked this pull request as ready for review March 3, 2026 11:41
@lilith218 lilith218 requested review from bvtrach and martin-beck March 3, 2026 11:41
@lilith218 lilith218 marked this pull request as draft March 3, 2026 13:52
@lilith218 lilith218 marked this pull request as draft March 3, 2026 13:52
@lilith218 lilith218 force-pushed the lilith/mv-bm-folder branch from 599513e to 19580d5 Compare March 3, 2026 14:45
@lilith218
Copy link
Member Author

Create an issue to have a neater way to define or configure gen-ws. It should be controlled in one place.

@lilith218 lilith218 marked this pull request as ready for review March 3, 2026 14:50
Copy link
Collaborator

@bvtrach bvtrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I got all the implications of the change, but looks good to me so far. I'd let Martin approve too.

bvtrach
bvtrach previously approved these changes Mar 3, 2026
martin-beck
martin-beck previously approved these changes Mar 3, 2026
Copy link
Collaborator

@martin-beck martin-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm

lilith218 added 13 commits March 3, 2026 17:51
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
Signed-off-by: Lilith Oberhauser <lilith.oberhauser@huawei.com>
@lilith218 lilith218 merged commit d26f221 into open-s4c:main Mar 3, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants