sdk-logs: default event timestamp on emit#8114
sdk-logs: default event timestamp on emit#8114jeet7122 wants to merge 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8114 +/- ##
============================================
- Coverage 90.33% 90.32% -0.01%
+ Complexity 7614 7612 -2
============================================
Files 839 839
Lines 22913 22913
Branches 2285 2285
============================================
- Hits 20698 20696 -2
Misses 1505 1505
- Partials 710 712 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the clarification! I reverted the behavior change and updated the setTimestamp javadoc to align with the spec. |
|
I’ve updated the javadocs to align with the spec and pushed the changes. |
|
Closing because the issue is already solved in #8104. In the future, look out for existing PRs for an issue to avoid wasted effort. If there's an existing PR, the approach is reasonable, and the author is responsive, it will be preferred over later PRs. Thanks! |
Fixes #8097
What this changes
*Default event timestamp to
clock.now()inSdkLogRecordBuilder.emit()when not explicitly set.setTimestampjavadoc (timestamp should default at emit time).emit_NoFieldstest accordingly.Testing
Ran
:sdk:logs:testOpening as a draft PR to coordinate and avoid duplicate work if someone else is already working on this.