Fix inverted condition in LegacySpanProcessorInstrumentation#finishSpans#8145
Merged
jack-berg merged 1 commit intoopen-telemetry:mainfrom Mar 6, 2026
Merged
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8145 +/- ##
============================================
+ Coverage 90.28% 90.29% +0.01%
Complexity 7649 7649
============================================
Files 843 843
Lines 23059 23059
Branches 2309 2309
============================================
+ Hits 20818 20822 +4
+ Misses 1520 1518 -2
+ Partials 721 719 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
approved these changes
Mar 5, 2026
Contributor
Author
|
recheck |
Member
|
/easycla |
Contributor
Author
|
recheck |
anuraaga
approved these changes
Mar 5, 2026
Contributor
anuraaga
left a comment
anuraaga
left a comment
There was a problem hiding this comment.
Thanks! Sorry about that
Member
|
/easycla |
antonio-mazzini
force-pushed
the
fix-legacy-span-processor-metric
branch
from
141e315 to
95029b8
Compare
The condition checking for error was inverted, preventing the processedSpans metric from being reported correctly when spans complete without errors.
antonio-mazzini
force-pushed
the
fix-legacy-span-processor-metric
branch
from
95029b8 to
ad14b0b
Compare
Contributor
|
Thank you for your contribution @antonio-mazzini! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8142
Summary
Fix the inverted condition in
LegacySpanProcessorInstrumentation#finishSpans()that prevents theprocessedSpansmetric from being reported correctly.The comment states "Legacy metrics only record when no error", but the condition was
error != null(records only when there IS an error). Changed toerror == nullto match the intended behavior.Changes
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/LegacySpanProcessorInstrumentation.java: Changederror != nulltoerror == nullinfinishSpans()method.