You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This doesn't solve the version db management. The issue with that is that we have to figure out when to use --overwrite-version. We could avoid this issue by comparing the version file with the one from the branch we want to merge into and only add the flag if they're not identical.
Correct, this doesn't solve anything with versioning and just adds a simple formatter. I mentioned it in the other discussion as a starting point for generic vcpkg helper pre-commit hooks.
The issue with that is that we have to figure out when to use --overwrite-version. We could avoid this issue by comparing the version file with the one from the branch we want to merge into and only add the flag if they're not identical.
How would you determine the base branch (merge target) on the developer machine where this hook is run?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality of life improvement
Using pre-commit hook to automatically format files
Install and enable pre-commit in your local git clone to automatically
have manifest files formatted whenever you
git commitsomething.