Add midi connect controller action #311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvengen
commented
Jun 12, 2020
Comment on lines
+60
to
+63
| /// arbitrary-length data (TODO use this instead of data) | ||
| unsigned char *dataList; | ||
| unsigned int dataListSize; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I think this is still a little ugly, prehaps this could be merged with data. Then all instances of data could receive either a single value or an array.
Contributor
Author
There was a problem hiding this comment.
Shall I try to combine data, dataList and dataListSize?
When reading data has a single value, it is assumed to be of size one (i.e. "data": 5 is assumed to be equivalent to "data": [5]). When writing, a single element is writting as "data": 5 whereas multiple elements are written as an array.
wvengen
force-pushed
the
feature/midi-connect
branch
from
c2895e2 to
fca75ce
Compare
This was referenced Jun 22, 2020
wvengen
force-pushed
the
feature/midi-connect
branch
from
e11b03a to
9f13979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some controllers may need some setup by midi messages.
This adds support for sending this, as defined in the ctlr file, when the port is connected.
Tested on the Launchpad X (#309), where it is used to enable the session mode on connection.