Don't attempt to memcpy() zero bytes #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add_rtattr_nest() is called in several places in the code. As part of its operation, it calls add_rtattr(nm type, NULL, 0) which results in NULL and 0 being passed to memcpy(). This fails with -Werror=nonnull on recent GCC. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
|
It's possible that a future C standard will make this valid, too, but for now it's incorrect C without the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_rtattr_nest()is called in several places in the code. As part of its operation, it callsadd_rtattr(nm type, NULL, 0)which results inNULLand 0 being passed tomemcpy(). This fails with-Werror=nonnullon recent GCC.