Conversation
ghost
left a comment
There was a problem hiding this comment.
generally looks good to me, just lots of small stuff.
xml/osc_building.xml
Outdated
| <listitem> | ||
| <para> | ||
| a <filename>_service</filename> file | ||
| <remark>toms 2017-09-04: is this really needed? Or is it optional?</remark> |
There was a problem hiding this comment.
It is needed only when you specify external resources, like a git repository.
|
|
||
| ingredients: <co xml:id="co.obs.building.ai.ingredients"/> | ||
| packages: | ||
| - <replaceable>MY_RPM_PACKAGE</replaceable> |
There was a problem hiding this comment.
Can you also add commented out example lines how to integrate upstream git sources?
eg
build:
...
# git:
# - https://github.com/probonopd/QtQuickApp.git
There was a problem hiding this comment.
See below. 😉
Yes, the idea was to separate these methods to remove clutter. One example with RPM packages only and one example directly from source code.
| - linuxdeployqt | ||
| - cmake | ||
| git: | ||
| - &gitupstream1;.git |
There was a problem hiding this comment.
ah ... here you go ...
please note that this works also with svn, bzr, hg
There was a problem hiding this comment.
Good to know. In this case, the git keyword is then svn, bzr, and hg, right?
|
Did I miss the exact specification between "build" packages and "ingredients"? BuildRequires vs incorporated packages into the image. It is also worth to note that the main tooling for building appimages is inside of pkg2appimage package by default. This package contains also a list of packages which get uninstalled at the end, because they are considered base packages always provided by the linux OS by default. |
There is the |
|
@sknorr @adrianschroeter Thanks for all comments and remarks! 👍 They are integrated now. Apart from them, I still don't get some details. Maybe you can answer my questions:
I've tried to build an AppImage for our example projects (see https://build.opensuse.org/package/show/home:obsgeeko/my-first-obs-package) but it still fails. 😢 Could you have a look and give me some hints what did I miss? Thanks! |
|
linuxdeployqt is one possible way to build appimage containers provided by appimage upstream. The qt inside the name is only there because it is using itself the qt libraries, but the tool can also be used for non-Qt appimage containers. IIRC the double usage was needed as workaround for some bug for some time, but should not be needed anymore. |
I've integrated a section about AppImages. It contains still some remarks which I couldn't solve yet, but I guess, it can be reviewed.
If you could have a look, it would be very helpful. Thanks!