Skip to content

Integrate how to build AppImages#84

Open
tomschr wants to merge 5 commits intomasterfrom
feature/appimage2
Open

Integrate how to build AppImages#84
tomschr wants to merge 5 commits intomasterfrom
feature/appimage2

Conversation

@tomschr
Copy link
Contributor

@tomschr tomschr commented Sep 5, 2017

I've integrated a section about AppImages. It contains still some remarks which I couldn't solve yet, but I guess, it can be reviewed.

If you could have a look, it would be very helpful. Thanks!

@tomschr tomschr self-assigned this Sep 5, 2017
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally looks good to me, just lots of small stuff.

<listitem>
<para>
a <filename>_service</filename> file
<remark>toms 2017-09-04: is this really needed? Or is it optional?</remark>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed only when you specify external resources, like a git repository.


ingredients: <co xml:id="co.obs.building.ai.ingredients"/>
packages:
- <replaceable>MY_RPM_PACKAGE</replaceable>
Copy link
Member

@adrianschroeter adrianschroeter Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add commented out example lines how to integrate upstream git sources?
eg

build:
...
#  git:
#    - https://github.com/probonopd/QtQuickApp.git

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below. 😉
Yes, the idea was to separate these methods to remove clutter. One example with RPM packages only and one example directly from source code.

- linuxdeployqt
- cmake
git:
- &gitupstream1;.git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ... here you go ...

please note that this works also with svn, bzr, hg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. In this case, the git keyword is then svn, bzr, and hg, right?

@adrianschroeter
Copy link
Member

Did I miss the exact specification between "build" packages and "ingredients"?

BuildRequires vs incorporated packages into the image.

It is also worth to note that the main tooling for building appimages is inside of pkg2appimage package by default. This package contains also a list of packages which get uninstalled at the end, because they are considered base packages always provided by the linux OS by default.

@tomschr
Copy link
Contributor Author

tomschr commented Sep 7, 2017

Did I miss the exact specification between "build" packages and "ingredients"?

There is the calloutlist in line 327 after the listing which explains a bit the difference between "build" and "ingredients". However, this can be improved, I guess.

@tomschr
Copy link
Contributor Author

tomschr commented Sep 7, 2017

@sknorr @adrianschroeter Thanks for all comments and remarks! 👍 They are integrated now.

Apart from them, I still don't get some details. Maybe you can answer my questions:

  1. What is this package linuxdeployqt inside the build/packages section? What it is used for? Do I have to use it or can I build an AppImage without this?
  2. Does the linuxdeployqt package has anything to do with Qt?
  3. Why is the command linuxdeployqt used twice in the appimage.yml file for osc (line 29+30)?

I've tried to build an AppImage for our example projects (see https://build.opensuse.org/package/show/home:obsgeeko/my-first-obs-package) but it still fails. 😢 Could you have a look and give me some hints what did I miss? Thanks!

@adrianschroeter
Copy link
Member

linuxdeployqt is one possible way to build appimage containers provided by appimage upstream.

The qt inside the name is only there because it is using itself the qt libraries, but the tool can also be used for non-Qt appimage containers.

IIRC the double usage was needed as workaround for some bug for some time, but should not be needed anymore.

@tomschr tomschr added the DO_NOT_MERGE Do not push the merge button even if it's possible label Dec 5, 2019
@Wabri Wabri mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO_NOT_MERGE Do not push the merge button even if it's possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants