Skip to content

Conversation

@YpXstyle
Copy link

@YpXstyle YpXstyle commented Aug 6, 2025

This modification has been optimized for hard coding to avoid program exceptions and errors!
For example, when the internationalization language configuration is set to "en", there is no problem using it. However, if other international languages (Korean, Japanese, Chinese, etc.) are used, the column name may no longer be "Adapter", but may be "适配器" or "접합ち", which will result in click event failure and functionality failure.
Add Chinese Simplified internationalization language configuration and address the issue of garbled Chinese or Korean characters in Arial font. Change Arial font to Dialog font

…ard coded table column names

-Introduce resource bundles to replace hard coded string values
-Update code to use key values from the new resource bundle
…ngual support

-Add Simplified Chinese translation files to cover all modules and components - update existing language translations, including German and English
-Revise the font settings of some interfaces and unify the use of Dialog font
@YpXstyle YpXstyle changed the title Bug fixes Add Simplified Chinese internationalization configuration; Optimize hard coded abnormal click events Aug 7, 2025
@swltr
Copy link
Member

swltr commented Oct 16, 2025

@YpXstyle Thank you for this PR! It took me a while to get to look at this, unfortunately.

I think adjusting the fonts to allow better internationalization makes sense, and it would be fine to integrate those changes.

As for the Chinese translation, it's great that you have put the work into it. I am hesitant to integrate it into this project, though, as we do not have the resources to continuously maintain it here. Maybe it would be better to maintain the Chinese property files in a separate project that offers a JAR file you can drop into the openTCS class path instead?

I noticed that there are also changes in the English and German bundle files where special encoded characters are used. The changes consist of making the encoding sequence upper case. I'd consider those changes unnecessary and would prefer to stick to the established lower-case sequences, keeping the diff minimal.

What do you think of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants