APPLE: Enabling Shap-E to run on Apple Silicon GPUs via Metal Performance Shaders (MPS) Acceleration#159
Open
s-bhatia1216 wants to merge 1 commit intoopenai:mainfrom
Open
APPLE: Enabling Shap-E to run on Apple Silicon GPUs via Metal Performance Shaders (MPS) Acceleration#159s-bhatia1216 wants to merge 1 commit intoopenai:mainfrom
s-bhatia1216 wants to merge 1 commit intoopenai:mainfrom
Conversation
* _extract_into_tensor(): CPU gather → MPS tensor to bypass unsupported advanced indexing. * Notebooks auto-select mps / cuda / cpu. * Verified on M4 Pro & M4 Max (macOS 15.4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APPLE: Enabling Shap-E to run on Apple Silicon GPUs via Metal Performance Shaders (MPS) Acceleration
Apple-Silicon (MPS) Support for Shap-E
Pull-Request
What this PR delivers:
shap_e/diffusion/gaussian_diffusion.pythat runs the indexing operation on CPU and then moves the tensor to MPS.mps → cuda → cpu) instead of CUDA-only.Motivation
Shap-E falls back to CPU on Apple M-series machines because certain indexing ops are not yet supported by PyTorch-MPS. This PR removes that blocker, giving native-GPU performance on macOS without sacrificing CUDA/CPU compatibility.
Running an example notebook
Validation checklist
Notebook test
Execute
sample_text_to_3d.ipynband 'sample_image_to_3d.ipynb end-to-end; generation succeed and shows expected geometry.Performance
Verify runtime improvements of Shap-E generations via the GPU over CPU on an M-series chip via the 'time' module in Python.
Commit message (for squash)
Reviewer notes
mainhas diverged before merging.License
This contribution is released under Shap-E's original MIT License.