fix: modernize Dockerfiles (fix broken builds, remove deprecated dependencies)#1199
Open
Symlink420 wants to merge 1 commit intoopenbullet:masterfrom
Open
fix: modernize Dockerfiles (fix broken builds, remove deprecated dependencies)#1199Symlink420 wants to merge 1 commit intoopenbullet:masterfrom
Symlink420 wants to merge 1 commit intoopenbullet:masterfrom
Conversation
- Update Node.js image from 20.9.0 to 22 (LTS) - Replace deprecated NodeSource setup scripts with Debian nodejs packages - Remove abandoned webdrivermanager pip package (Selenium 4.6+ has built-in Selenium Manager) - Remove unstable Debian repo hack in Dockerfile - Remove deprecated apt-key usage in Dockerfile.remote - Consolidate RUN layers to reduce image size - Use npm ci instead of npm install for reproducible builds - Switch firefox to firefox-esr (available in Debian stable repos)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes all three Dockerfiles (
Dockerfile,Dockerfile.build,Dockerfile.remote) by replacing deprecated/abandoned tools that cause build failures.Changes
20.9.0to22(current LTS)setup_current.x/setup_lts.xscripts (NodeSource deprecated these setup scripts, breaking Docker builds)webdrivermanagerpip package (last release 2020) — Selenium 4.6+ includes built-in Selenium Manager that auto-downloads browser driversdeb.debian.org/debian/ unstable) that could cause unpredictable build breaksapt-keyusage inDockerfile.remoteRUNlayers to reduce final image sizenpm install→npm cifor reproducible, faster buildsfirefox→firefox-esr(available directly from Debian stable repos, no PPA needed)Why
Several tools used in the Dockerfiles have been deprecated or abandoned, causing Docker builds to fail:
setup_current.xscriptwebdrivermanagerpip package hasn't been updated since 2020unstableDebian repos is fragile and can break at any timeThese are all resolved by using packages available directly in Debian bookworm repos.