Replace deprecated packages: migrate to BCrypt.Net-Next and Asp.Versi…#1201
Open
Symlink420 wants to merge 1 commit intoopenbullet:masterfrom
Open
Replace deprecated packages: migrate to BCrypt.Net-Next and Asp.Versi…#1201Symlink420 wants to merge 1 commit intoopenbullet:masterfrom
Symlink420 wants to merge 1 commit intoopenbullet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces several abandoned or deprecated libraries with their modern, actively maintained successors. This improves the security posture of the application and ensures compatibility with .NET 8+ standards.
Key Changes
Replaced the abandoned BCrypt.Net-Core (unmaintained since 2017) with BCrypt.Net-Next.
Resolved breaking changes related to the removal of SaltRevision in the new library.
Updated RuriLib crypto functions and OpenBullet2.Web mapper profiles to use the modern hashing API.
Replaced the deprecated Microsoft.AspNetCore.Mvc.Versioning with Asp.Versioning.Mvc (the official successor).
Refactored
Program.cs
to use the new service registration pattern (AddApiVersioning().AddApiExplorer()).
Introduced
GlobalUsings.cs
in the OpenBullet2.Web project.
Centralized Asp.Versioning namespaces to avoid adding using directives to every single controller (50+ files), keeping the codebase clean.
Updated Swashbuckle.AspNetCore to the latest stable version.
Updated
ConfigureSwaggerOptions.cs
to integrate with the new IApiVersionDescriptionProvider from Asp.Versioning.
Verification Results
Automated Tests
RuriLib.Tests: PASSED (202/203 - 1 skipped).
RuriLib.Http.Tests: PASSED.
RuriLib.Parallelization.Tests: PASSED.
RuriLib.Proxies.Tests: PASSED.
Build
Status: SUCCESS ✅
Verified on local host using .NET 8 SDK. All project references and dependency chains are intact.