Fix Amazon WAF Captcha support for CapMonster Cloud (#1151)#1203
Open
Symlink420 wants to merge 2 commits intoopenbullet:masterfrom
Open
Fix Amazon WAF Captcha support for CapMonster Cloud (#1151)#1203Symlink420 wants to merge 2 commits intoopenbullet:masterfrom
Symlink420 wants to merge 2 commits intoopenbullet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the NotSupportedException when attempting to solve Amazon WAF Captchas using the CapMonster Cloud service.
As the current version of
CaptchaSharp
(2.1.0) does not yet implement the AmazonTaskProxyless task type for CapMonster Cloud, I have added a custom service implementation within RuriLib to bridge this gap.
Changes
Added
CapMonsterCloudAmazonWafService
: A custom service class that implements the AmazonTaskProxyless API for CapMonster Cloud, including task creation and polling logic.
Modified
CaptchaServiceFactory
: Updated to return the new custom service when
CapMonsterCloud
is selected as the provider.
Fixes
Fixes #1151
Verification Plan
Verified that the custom service correctly formats the JSON request according to CapMonster Cloud's AmazonTaskProxyless documentation.
Verified task creation and solution polling logic.
Manual verification on a live Amazon WAF protected site (recommended for the reviewer/user).