Skip to content

Incorporating suggestions from @gordonje #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aepton wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Incorporating suggestions from @gordonje #104

aepton wants to merge 2 commits into from

Conversation

@aepton
Copy link
Contributor

@aepton aepton commented Dec 16, 2017

  1. Adds filing_action to CommitteeAttributeUpdate, same as with Transaction
  2. Gives Transaction a repeated notes field instead of discrete "description" and "notes" fields
  3. Adds free-text field for "type" to Committee and gets rid of CommitteeType
  4. Removes time field from coverage_start_date and coverage_end_date
  5. Adds repeated "totals" field on Filing
  6. Makes Filing.election field optional, renames it to "designation"
  7. Adds is_rejected field to Transaction.amount
  8. Makes Transaction.date optional

This was referenced Dec 16, 2017
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

OCDEP: Campaign Finance Filings

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aepton @jpmckinney