Open
Conversation
Codecov Report
@@ Coverage Diff @@
## devel #996 +/- ##
==========================================
- Coverage 84.45% 81.84% -2.61%
==========================================
Files 58 65 +7
Lines 5036 6220 +1184
Branches 1092 1372 +280
==========================================
+ Hits 4253 5091 +838
- Misses 508 755 +247
- Partials 275 374 +99
Continue to review full report at Codecov.
|
Member
|
It's almost impossible to tell what this PR adds because it includes all of the changes of the other branch. @matthiaskoenig can you open a branch on this repository, please, for the other work and then make a pull request from this branch targetting that new branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of feature
User Defined Constraint: This new feature from fbc-v3 has been added to COBRApy as well as to JSON and other formats also. A user can now add his own constraints to the model. He can do this even more easily by just passing the constraint expression (for eg. "2v1 - 3v2*v2 +0.4 * v3" where v1, v2 and v3 are either reaction ids to define fluxes or some variable) along with the lower and upper bounds.
Tests
Tests for the functionality has been added along with a new example model.
Note: