Skip to content

juniper: handle rare exception and increase timeout #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nitinsoniism wants to merge 1 commit into
base: main
Choose a base branch
from
Open

juniper: handle rare exception and increase timeout #622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions topo/node/juniper/juniper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var (
// For committing a very large config
scrapliOperationTimeout = 300 * time.Second
// Wait for PKI cert infra
certGenTimeout = 10 * time.Minute
certGenTimeout = 15 * time.Minute
// Time between polls
certGenRetrySleep = 30 * time.Second
// Wait for config mode
Expand Down Expand Up @@ -130,7 +130,7 @@ func (n *Node) waitConfigInfraReadyAndPushConfigs(configs []string) error {
for time.Since(start) < configModeTimeout {
multiresp, err := n.cliConn.SendConfigs(configs)
Copy link
Contributor Author

@nitinsoniism nitinsoniism May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also exploring - passing a higher timeout to SendConfigs as "options". The default might be low.

Copy link
Contributor

@marcushines marcushines Jun 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping need update on cla for that

if err != nil {
if strings.Contains(err.Error(), "errPrivilegeError") {
if strings.Contains(err.Error(), "errPrivilegeError") || strings.Contains(err.Error(), "errTimeoutError") {
log.Infof("Config mode not ready. Retrying in %v. Node %s, Resp %v", configModeRetrySleep, n.Name(), err)
} else {
return fmt.Errorf("failed pushing configs: %v", err)
Expand Down
Loading