Conversation
* Add CI for KFP local runner * Set ocr to False * filter vlm runner * Change OCR option to use 'rapidocr' * Update OCR parameters in local_run.py * Add option to run from branch or pr * Remove OCR options from local_run.py Removed OCR options from docling_convert_standard call. * Change permissions of local_outputs directory * trigger on workflow edits too * Update base container images for Docling Pipelines * Add OCR option to docling_convert_standard call * Update base image references in constants.py * Pin kfp version to 2.14.6 in workflow * Update base container images for Kubeflow Pipelines * Configure Quay registry login in workflow Added environment variable for Quay registry and login step. * Configure Quay registry login in workflow Added environment variable for Quay registry and login step. * Remove empty new line * Refactor GitHub Actions workflow to launch EC2 runner and update container images - Introduced a new job to launch an EC2 runner for data processing. - Updated the container images for both standard and VLM pipelines to use `quay.io/aipcc/docling/cuda-ubi9`. - Enhanced the test-local-pipelines job to depend on the EC2 runner and adjusted Python setup steps. - Added a job to stop the EC2 runner after the pipeline execution.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Change pip installation method to ensurepip before upgrading.
Added Docker setup steps to the workflow.
Updated the setup workflow to include Podman installation and configuration alongside Python.
Updated Podman socket management for improved compatibility.
Updated Podman socket handling and permissions for compatibility.
Updated setup for Docker instead of Podman in CI workflow.
Updated user group management for Docker access.
Enhanced the execute-kfp-localrunners workflow to allow overriding of PYTHON_BASE_IMAGE and DOCLING_BASE_IMAGE through input parameters. Updated constants to use environment variables for base images.
…g pipelines to use quay.io/amaredia/aipcc-docling-image
2 tasks
|
🔀 Merge Conflict Detected This pull request has merge conflicts that must be resolved before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI for KFP local runner
Set ocr to False
filter vlm runner
Change OCR option to use 'rapidocr'
Update OCR parameters in local_run.py
Add option to run from branch or pr
Remove OCR options from local_run.py
Removed OCR options from docling_convert_standard call.
Change permissions of local_outputs directory
trigger on workflow edits too
Update base container images for Docling Pipelines
Add OCR option to docling_convert_standard call
Update base image references in constants.py
Pin kfp version to 2.14.6 in workflow
Update base container images for Kubeflow Pipelines
Configure Quay registry login in workflow
Added environment variable for Quay registry and login step.
Added environment variable for Quay registry and login step.
Remove empty new line
Refactor GitHub Actions workflow to launch EC2 runner and update container images
quay.io/aipcc/docling/cuda-ubi9.Description
How Has This Been Tested?
Merge criteria: