-
Notifications
You must be signed in to change notification settings - Fork 187
chore: Added backoff exception #4699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: Added backoff exception #4699
Conversation
3fca698 to
6465add
Compare
6465add to
bf7aaab
Compare
bf7aaab to
de3d12c
Compare
|
@UsamaSadiq @openedx/committers-course-discovery could anyone please check and help review/merge this PR |
|
@skumargupta83 I can't access the linked ticket. |
|
HI @UsamaSadiq, |
|
@UsamaSadiq @openedx/committers-course-discovery |
|
@UsamaSadiq @openedx/committers-course-discovery |
|
Hi @UsamaSadiq - thanks for the original feedback on this PR. The ticket is now posted - anything else you need from the team? |
|
@skumargupta83 My concern is more towards if this change is really needed for OpenedX community? The code seems only related to a fix of an internal edX job. |
|
Hi @UsamaSadiq, |
Thanks for the context. @pwnage101 would be a better reviewer for this change. I'll help out in merging this PR if needed once it is approved by Troy. |
|
Hi @pwnage101, |
https://2u-internal.atlassian.net/browse/PROD-4437
This PR introduces a backoff exception decorator to handle transient API failures gracefully.
Title: [course-discovery] [edx-ingest-getsmarter-data] fetch_getsmarter_products() should retry
Key details Description
The Problem
The course-discovery k8s job edx-ingest-getsmarter-data regularly fails on networking errors and server errors when calling GetSmarter APIs. The k8s job itself is configured to restart the job when this occurs, but this starts the job from the very beginning and pollutes our job logs and job history with failed pods, and makes the job take hours longer than otherwise needed.