Skip to content

Conversation

@ayub02
Copy link
Contributor

@ayub02 ayub02 commented Dec 11, 2025

Notification default preferences have been changed (see PR). Plus i wanted to do some refactoring of both learner and educator facing notification docs. This PR has those changes.

@ayub02 ayub02 marked this pull request as ready for review December 12, 2025 05:07
@ayub02 ayub02 requested a review from sarina December 12, 2025 05:08
Copy link
Contributor

@sarina sarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ayub02 - given the Educator's page and the Learner's page is approximately identical, I would lean to keeping the identical information in one place (probably the Learner page) and pointing the Educator's page at the Learners page. Otherwise the pages may fall out of sync if we update one but forget the other.

@ayub02
Copy link
Contributor Author

ayub02 commented Dec 15, 2025

@sarina i'm working on it. What should i say in educator docs? "Please see {learner notification docs link}?

@sarina
Copy link
Contributor

sarina commented Dec 15, 2025

What should i say in educator docs? "Please see {learner notification docs link}?

Something like that. Maybe, "For more detail on the different types of notifications and preferences available for all users on the platform, see {learner notifications docs link}." And in the Educator's docs, add any detail on any notifications (if there are any) that only apply to Educators

@ayub02
Copy link
Contributor Author

ayub02 commented Dec 16, 2025

@sarina the build failed and logs mention 1 warning but i'm unable to find it in logs.

build finished with problems, 1 warning (with warnings treated as errors).

@sarina
Copy link
Contributor

sarina commented Dec 17, 2025

@ayub02 the problem is the flat-table. That's been merged to main. If you sync your fork and merge main into this branch, I believe the issue will be resolved.

@ayub02
Copy link
Contributor Author

ayub02 commented Dec 18, 2025

Done. Table is now rendering fine. Thanks for introducing this table type.

@sarina sarina merged commit b28219d into openedx:main Dec 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants