-
Notifications
You must be signed in to change notification settings - Fork 78
Docs: Updated and refactored notifications documentation with new default preferences #1353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sarina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ayub02 - given the Educator's page and the Learner's page is approximately identical, I would lean to keeping the identical information in one place (probably the Learner page) and pointing the Educator's page at the Learners page. Otherwise the pages may fall out of sync if we update one but forget the other.
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
source/educators/concepts/communication/notifications_preferences.rst
Outdated
Show resolved
Hide resolved
|
@sarina i'm working on it. What should i say in educator docs? "Please see {learner notification docs link}? |
Something like that. Maybe, "For more detail on the different types of notifications and preferences available for all users on the platform, see {learner notifications docs link}." And in the Educator's docs, add any detail on any notifications (if there are any) that only apply to Educators |
|
@sarina the build failed and logs mention 1 warning but i'm unable to find it in logs.
|
|
@ayub02 the problem is the |
|
Done. Table is now rendering fine. Thanks for introducing this table type. |
Notification default preferences have been changed (see PR). Plus i wanted to do some refactoring of both learner and educator facing notification docs. This PR has those changes.