Skip to content

Conversation

@hassan-raza-1
Copy link
Contributor

@hassan-raza-1 hassan-raza-1 commented Mar 25, 2025

Ticket
https://2u-internal.atlassian.net/browse/INF-1838

Description
To implement group notifications for staff regarding ORA submissions, we need to use the block_id as the group_id to group notifications accordingly.

@hassan-raza-1 hassan-raza-1 force-pushed the hraza/group_ora_notifications branch from d4de7b5 to d2d930a Compare March 25, 2025 17:55
@hassan-raza-1 hassan-raza-1 marked this pull request as draft March 25, 2025 18:55
@hassan-raza-1 hassan-raza-1 force-pushed the hraza/group_ora_notifications branch 2 times, most recently from 6b7b4c1 to b1bcd25 Compare March 25, 2025 20:44
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (2283906) to head (f5f4796).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2285   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         195      195           
  Lines       21624    21626    +2     
  Branches     1502     1502           
=======================================
+ Hits        20606    20608    +2     
  Misses        771      771           
  Partials      247      247           
Flag Coverage Δ
unittests 95.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hassan-raza-1 hassan-raza-1 force-pushed the hraza/group_ora_notifications branch 4 times, most recently from bc868a3 to 304bba1 Compare March 26, 2025 08:45
@hassan-raza-1 hassan-raza-1 marked this pull request as ready for review March 26, 2025 09:04
@hassan-raza-1 hassan-raza-1 changed the title feat: Group ora staff notifications [Draft] feat: Group ora staff notifications Mar 26, 2025
@hassan-raza-1 hassan-raza-1 force-pushed the hraza/group_ora_notifications branch from 304bba1 to f5f4796 Compare March 28, 2025 10:08
@nsprenkle nsprenkle merged commit 9b02c95 into openedx:master Apr 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants