Skip to content

Conversation

@AntonOfTheWoods
Copy link

Update outdated readme

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 10, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @AntonOfTheWoods!

This repository is currently maintained by @openedx/2u-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 10, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Dec 11, 2025
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 11, 2025
@e0d
Copy link

e0d commented Dec 11, 2025

@AntonOfTheWoods not sure why there's a failed test on this PR, potentially flaky test. Can you check if a rebase help?

@AntonOfTheWoods
Copy link
Author

@e0d , pretty sure I'm just above master. Is there something else I should rebase on?

In any case, I simply couldn't get tests to pass at all on current master, so either I'm holding it wrong, or the tests are very flakey indeed!

@e0d
Copy link

e0d commented Dec 12, 2025

@Lunyachek I was running the tests on @AntonOfTheWoods 's PR and it unrelated tests are failing. It looks like there are failures on master and I think you have the last commit there.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 12, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Dec 12, 2025
@AntonOfTheWoods
Copy link
Author

@mphilbrick211 , are you sure this should be labelled "waiting on author"? I'm pretty sure a minor edit to the readme shouldn't make completely unrelated tests fail, and @e0d also appears to have found the the current master branch also fails the same tests, so has nothing to do with my docs update.

@mphilbrick211
Copy link

@mphilbrick211 , are you sure this should be labelled "waiting on author"? I'm pretty sure a minor edit to the readme shouldn't make completely unrelated tests fail, and @e0d also appears to have found the the current master branch also fails the same tests, so has nothing to do with my docs update.

Hi @AntonOfTheWoods - "waiting on author" means the pull request is actively in progress and not yet ready for review. You can see a breakdown of the different statuses here. I'm not sure next steps on the failing checks, but perhaps @e0d can help.

@AntonOfTheWoods
Copy link
Author

@mphilbrick211 , are you sure this should be labelled "waiting on author"? I'm pretty sure a minor edit to the readme shouldn't make completely unrelated tests fail, and @e0d also appears to have found the the current master branch also fails the same tests, so has nothing to do with my docs update.

Hi @AntonOfTheWoods - "waiting on author" means the pull request is actively in progress and not yet ready for review.

Thanks, so it is indeed as I expected. If you look at the test failure it is utterly impossible that it is due to my changes. As @e0d mentioned, @Lunyachek may be the best to diagnose the underlying issue - but it is not possibly an issue with my contribution. He also agrees that the current tests are simply broken on the existing master HEAD. So it is also already broken without my changes. I will certainly be very keen to help fix bugs I didn't create when I understand the codebase better!

As such, I'm not sure "waiting for author" is the best status, as that will likely mean the people who can actually fix the broken existing state won't see it on their boards.

@e0d
Copy link

e0d commented Dec 19, 2025

@AntonOfTheWoods I appreciate your patience, I do need someone on the FE side to weigh in here so we can rebase your PR and get a green build. @Lunyachek Can you look at the issue on master?

@brian-smith-tcril @arbrandes FYI

@brian-smith-tcril
Copy link
Contributor

Made an issue #1395

@Lunyachek FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

5 participants