-
Notifications
You must be signed in to change notification settings - Fork 176
docs: updates for outdated references #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @AntonOfTheWoods! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@AntonOfTheWoods not sure why there's a failed test on this PR, potentially flaky test. Can you check if a rebase help? |
|
@e0d , pretty sure I'm just above In any case, I simply couldn't get tests to pass at all on current |
|
@Lunyachek I was running the tests on @AntonOfTheWoods 's PR and it unrelated tests are failing. It looks like there are failures on master and I think you have the last commit there. |
|
@mphilbrick211 , are you sure this should be labelled "waiting on author"? I'm pretty sure a minor edit to the readme shouldn't make completely unrelated tests fail, and @e0d also appears to have found the the current master branch also fails the same tests, so has nothing to do with my docs update. |
Hi @AntonOfTheWoods - "waiting on author" means the pull request is actively in progress and not yet ready for review. You can see a breakdown of the different statuses here. I'm not sure next steps on the failing checks, but perhaps @e0d can help. |
Thanks, so it is indeed as I expected. If you look at the test failure it is utterly impossible that it is due to my changes. As @e0d mentioned, @Lunyachek may be the best to diagnose the underlying issue - but it is not possibly an issue with my contribution. He also agrees that the current tests are simply broken on the existing master HEAD. So it is also already broken without my changes. I will certainly be very keen to help fix bugs I didn't create when I understand the codebase better! As such, I'm not sure "waiting for author" is the best status, as that will likely mean the people who can actually fix the broken existing state won't see it on their boards. |
|
@AntonOfTheWoods I appreciate your patience, I do need someone on the FE side to weigh in here so we can rebase your PR and get a green build. @Lunyachek Can you look at the issue on master? |
|
Made an issue #1395 @Lunyachek FYI |
Update outdated readme