-
Notifications
You must be signed in to change notification settings - Fork 4
Use "Open edX" trademark properly in the documentation #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 47 47
Lines 4310 4310
Branches 271 271
=======================================
Hits 3904 3904
Misses 317 317
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7883c26 to
142a69d
Compare
|
@felipemontoya do you want any of these builds to be required on this repo? (currently only the CLA check is) |
|
Thank you @sarina. The check looks to be reporting back to me.
That should be enough. I don't think that having the check as required is necessary but I will not merge it anyways if any of the builds are failing. However if it is customary that this check is required, please make it so. |
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR checks look good to me. The changes in the docs are also good and appreciated.
|
I don't think the docs build needs to be required, I was more asking about the other CI builds. Feel free to ping me at any point if you'd like any of the checks to be turned into required ones |

PR to test whether docs are building