Skip to content

Conversation

@sarina
Copy link
Contributor

@sarina sarina commented Jan 9, 2026

PR to test whether docs are building

@sarina sarina marked this pull request as draft January 9, 2026 14:36
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (a8956e3) to head (142a69d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files          47       47           
  Lines        4310     4310           
  Branches      271      271           
=======================================
  Hits         3904     3904           
  Misses        317      317           
  Partials       89       89           
Flag Coverage Δ
unittests 90.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarina sarina force-pushed the sarina/test-docs-build branch from 7883c26 to 142a69d Compare January 9, 2026 15:58
@sarina sarina marked this pull request as ready for review January 9, 2026 15:59
@sarina sarina requested a review from felipemontoya January 9, 2026 15:59
@sarina sarina changed the title docs: "Open edX" is an adjective Use "Open edX" trademark properly in the documentation Jan 9, 2026
@sarina
Copy link
Contributor Author

sarina commented Jan 9, 2026

@felipemontoya do you want any of these builds to be required on this repo? (currently only the CLA check is)

@felipemontoya
Copy link
Member

Thank you @sarina. The check looks to be reporting back to me.

image

That should be enough. I don't think that having the check as required is necessary but I will not merge it anyways if any of the builds are failing. However if it is customary that this check is required, please make it so.

Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checks look good to me. The changes in the docs are also good and appreciated.

@sarina
Copy link
Contributor Author

sarina commented Jan 9, 2026

I don't think the docs build needs to be required, I was more asking about the other CI builds. Feel free to ping me at any point if you'd like any of the checks to be turned into required ones

@sarina sarina merged commit 5e02075 into main Jan 9, 2026
10 checks passed
@sarina sarina deleted the sarina/test-docs-build branch January 9, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants