-
Notifications
You must be signed in to change notification settings - Fork 90
Solving PageRoute import and other issues on example app #3956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-23.x
Are you sure you want to change the base?
Solving PageRoute import and other issues on example app #3956
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
…into pageroute-example-app
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #3956 +/- ##
=============================================
Coverage 94.37% 94.37%
=============================================
Files 242 242
Lines 4282 4287 +5
Branches 1016 1017 +1
=============================================
+ Hits 4041 4046 +5
+ Misses 237 233 -4
- Partials 4 8 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @PKulkoRaccoonGang Can I get another review here? CC @brian-smith-tcril |
PKulkoRaccoonGang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. I tried running the example app from this PR by following the steps in the "How to test" it section, but I encountered the following errors. I also tried logging in through my locally running Tutor Open edX instance, but the errors still persist. Is there anything else I need to set up before following the "How to test" it instructions?
Access to XMLHttpRequest at 'http://local.openedx.io:8000/login_refresh' from origin 'http://localhost:8080' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
POST http://local.openedx.io:8000/login_refresh net::ERR_FAILED 401 (Unauthorized)
@PKulkoRaccoonGang It is also needed to patch CORS settings to bypass example app url. I updated the how to test it section with the instructions to create a tutor plugin to do that, try that and lets see if that fixes your errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! I tested it locally, and everything works as expected. I did notice some styling issues in the example app, but since this PR is specifically aimed at resolving the routing problems, it seems reasonable to handle the styling fixes in a separate issue (#4032).
I’ve added a minor comment about updating the documentation in the "Steps to install the example app" section. I believe making this update would simplify running the example app going forward 💯
|
|
||
| Steps to install the `example` app. | ||
|
|
||
| 1. `npm install` to install dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the instructions outlined in the "How to test it" section of this PR, would it make sense to update the "Steps to install the example app" section too? Since devstack has been deprecated, it seems worthwhile to update the documentation on how to run the example app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the readme with the instructions.
|
@PKulkoRaccoonGang I have addressed your comments, can you do another review? |
Description
It solves the following issues on example app:
Also upgrades the version for @edx/frontend-platform on example app.closes #3838.
Warning
Due to some code conflicts I had to regenerate the package-lock.json file.I am not sure if this may cause delay on this pr due to node 24 migration and related with the comment here #3687 and this ticket #3854
How to test it
A tutor plugin is required to patch CORS settings with the example app url:
paragon-example-app.py) in your tutor plugins folder (tutor plugins printrootto get the path)paragon-example-apptutor config save&&tutor dev restartThen run the example app:
npm installnpm run example:startDeploy Preview
Merge Checklist
exampleapp?Post-merge Checklist