Skip to content

feat!: better support header-only card use #3966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brian-smith-tcril wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

feat!: better support header-only card use #3966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Card/CardImageCap.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const CardImageCap = React.forwardRef(({
const [showImageCap, setShowImageCap] = useState(false);
const [showLogoCap, setShowLogoCap] = useState(false);

const wrapperClassName = `pgn__card-wrapper-image-cap ${orientation}`;
const wrapperClassName = `pgn__card-wrapper-image-cap ${orientation}${showLogoCap ? ' with-logo' : ''}`;

if (isLoading) {
return (
Expand Down
5 changes: 5 additions & 0 deletions src/Card/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,14 @@ This header displays a title, subtitle, and may contain actions.
<div>
<Card className="mb-2">
<Card.Header title="Title" />
<Card.Footer />
</Card>
<Card>
<Card.Header
title="Title"
subtitle="Subtitle"
/>
<Card.Footer />
</Card>
</div>
```
Expand Down Expand Up @@ -191,6 +193,7 @@ The `Card.Header` supports custom actions via the actions prop and renders them
</ActionRow>
}
/>
<Card.Footer />
</Card>
<Card>
<Card.Header
Expand All @@ -214,6 +217,7 @@ The `Card.Header` supports custom actions via the actions prop and renders them
</Dropdown>
}
/>
<Card.Footer />
</Card>
</div>
)}
Expand All @@ -235,6 +239,7 @@ Add ``size="sm"`` for smaller header content and actions.
}
size="sm"
/>
<Card.Footer />
</Card>
```

Expand Down
9 changes: 8 additions & 1 deletion src/Card/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ a.pgn__card {
.pgn__card-header-content {
display: flex;
flex-direction: column;
margin-top: map.get($spacers, 4\.5);
margin-top: var(--pgn-spacing-spacer-base);
overflow: auto;
text-align: start;
width: 100%;
Expand Down Expand Up @@ -164,6 +164,8 @@ a.pgn__card {
}

.pgn__card-header-actions {
display: flex;
align-items: center;
margin-top: var(--pgn-spacing-spacer-base);
margin-inline-start: var(--pgn-spacing-spacer-base);
flex-shrink: 0;
Expand Down Expand Up @@ -334,8 +336,13 @@ a.pgn__card {

&.vertical {
max-height: var(--pgn-size-card-image-vertical-max-height);

&.with-logo {
margin-bottom: var(--pgn-spacing-spacer-base);
}
}


.pgn__card-image-cap-loader {
.react-loading-skeleton {
margin-bottom: calc(-1 * var(--pgn-spacing-card-loading-skeleton-spacer));
Expand Down