-
Notifications
You must be signed in to change notification settings - Fork 90
refactor: run tests with node:test #4044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-23.x
Are you sure you want to change the base?
refactor: run tests with node:test #4044
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This PR demonstrates changing a few tests to run using Node's Test Runner instead of jest.
Running the tests with Node's native test runner is much faster than running them with Jest, but does not support some of the non-standard imports we're currently using like importing SCSS and SVG files into Paragon. I've tried getting them to work using things like
@nodejs-loaders/mediato support importing SVG files, and that does work but it conflicts with thetsxloader that we need to support TSX/JSX syntax. So I'm not sure we can use this approach to testing without major refactoring.It also doesn't support Jest test syntax so many test cases have to be changed, although in a systematic way. (e.g.
expect(tree).toMatchSnapshot();->t.assert.snapshot(tree);). This is a big disadvantage compared to Vitest.Time taken to run
npm test -- src/Button/Button*.test.tsx:node:test