Skip to content

Specify explicitly jmh-generator-annprocess as an annotation processor in jmh-samples pom.xml#165

Open
FBibonne wants to merge 1 commit intoopenjdk:masterfrom
FBibonne:fix-annotation-processor-for-samples
Open

Specify explicitly jmh-generator-annprocess as an annotation processor in jmh-samples pom.xml#165
FBibonne wants to merge 1 commit intoopenjdk:masterfrom
FBibonne:fix-annotation-processor-for-samples

Conversation

@FBibonne
Copy link

@FBibonne FBibonne commented Dec 23, 2025

When building with maven jmh-samples with a jdk version 22+ , the annotation processor jmh-generator-annprocess is not executed and files and classes generated by jmh are not included in the jar. Then there is an error at runtime when trying to execute samples with command line such as java -jar target/benchmarks.jar JMHSample_01 : Exception in thread "main" java.lang.RuntimeException: ERROR: Unable to find the resource: /META-INF/BenchmarkList

This error happens because the jmh-sample pom.xml does not explicitly set jmh-generator-annprocess as an annotation processor path. This PR aims to correct this issue like the PR #125


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.org/jmh.git pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/165.diff

Using Webrev

Link to Webrev Comment

- specify explicitly jmh-generator-annprocess dependency in <annotationProcessorPaths>

Signed-off-by: Fabrice Bibonne <fabrice.bibonne@courriel.eco>
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 23, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

Hi @FBibonne, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user FBibonne" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@FBibonne
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 17, 2026
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2026

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Feb 1, 2026
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant