Specify explicitly jmh-generator-annprocess as an annotation processor in jmh-samples pom.xml#165
Conversation
- specify explicitly jmh-generator-annprocess dependency in <annotationProcessorPaths> Signed-off-by: Fabrice Bibonne <fabrice.bibonne@courriel.eco>
|
Hi @FBibonne, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user FBibonne" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
/signed |
|
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
When building with maven jmh-samples with a jdk version 22+ , the annotation processor jmh-generator-annprocess is not executed and files and classes generated by jmh are not included in the jar. Then there is an error at runtime when trying to execute samples with command line such as
java -jar target/benchmarks.jar JMHSample_01:Exception in thread "main" java.lang.RuntimeException: ERROR: Unable to find the resource: /META-INF/BenchmarkListThis error happens because the jmh-sample pom.xml does not explicitly set jmh-generator-annprocess as an annotation processor path. This PR aims to correct this issue like the PR #125
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/165/head:pull/165$ git checkout pull/165Update a local copy of the PR:
$ git checkout pull/165$ git pull https://git.openjdk.org/jmh.git pull/165/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 165View PR using the GUI difftool:
$ git pr show -t 165Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/165.diff
Using Webrev
Link to Webrev Comment