8373708: [lworld] InstanceKlass::null_marker_offset(int i) is misleading

[fparain]

Please review this very small change to rename InstanceKlass::null_marker_offset(int i) into InstanceKlass::field_null_marker_offset(int i) to highlight the fact that the method returns the null marker offset of a given field and not the null marker offset for the current class.

Thank you.

Fred

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8373708: [lworld] InstanceKlass::null_marker_offset(int i) is misleading (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Author)
• Coleen Phillimore (@coleenp - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1835/head:pull/1835
$ git checkout pull/1835

Update a local copy of the PR:
$ git checkout pull/1835
$ git pull https://git.openjdk.org/valhalla.git pull/1835/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1835

View PR using the GUI difftool:
$ git pr show -t 1835

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1835.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fparain! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fparain This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373708: [lworld] InstanceKlass::null_marker_offset(int i) is misleading

Reviewed-by: stefank, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 120 new commits pushed to the lworld branch:

• 4ffaf14: 8369045: [lworld] valhalla/valuetypes/WeakReferenceTest.java has an unschedulable graph
• 328cfbe: 8372806: [lworld] x64: save bad values instead of rfp and lr above the extension space
• fe500a0: 8367408: [lworld] runtime/cds/appcds/methodHandles/MethodHandlesGeneralTest.java#aot fails
• ... and 117 more: https://git.openjdk.org/valhalla/compare/1e6e72e246608d872d7733559da7ba29ed10f69a...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (a84afdcb)

[stefank]

Looks good. Thanks for fixing!

[fparain]

Thanks @stefank for the review.

[fparain]

/integrate

[openjdk]

@fparain This pull request has not yet been marked as ready for integration.

[coleenp]

Looks good!

[fparain]

Thanks @coleenp for the review.

[fparain]

/integrate

[openjdk]

Going to push as commit 90dfb43.
Since your change was applied there have been 120 commits pushed to the lworld branch:

• 4ffaf14: 8369045: [lworld] valhalla/valuetypes/WeakReferenceTest.java has an unschedulable graph
• 328cfbe: 8372806: [lworld] x64: save bad values instead of rfp and lr above the extension space
• fe500a0: 8367408: [lworld] runtime/cds/appcds/methodHandles/MethodHandlesGeneralTest.java#aot fails
• ... and 117 more: https://git.openjdk.org/valhalla/compare/1e6e72e246608d872d7733559da7ba29ed10f69a...lworld

Your commit was automatically rebased without conflicts.

[openjdk]

@fparain Pushed as commit 90dfb43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.