8373930: [lworld] Restore Objects.equals use of identity check #1836
+4
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing the condition on --enable-preview. Correct the .equals method of SimplValueGraphs.SimpleValue. Revert "8366841: [lworld] Objects.equals without identity comparison"
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Collaborator
Author
|
If you are looking for something easy to get started in the new year, consider reviewing this backout restoring Object.equals to its previous implementation. |
Collaborator
Author
|
/touch |
|
@RogerRiggs The pull request is being re-evaluated and the inactivity timeout has been reset. |
ryanhallock
reviewed
Jan 8, 2026
| * @param b an object to be compared with {@code a} for equality | ||
| * @see Object#equals(Object) | ||
| */ | ||
| @ForceInline |
There was a problem hiding this comment.
Is this still required? I thought the reasoning behind 8368884: #1643 was that equals was too large.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "8366841: [lworld] Objects.equals without identity comparison". (Almost all)
Removing the condition on --enable-preview.
Correct the .equals method in test SimplValueGraphs.SimpleValue.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1836/head:pull/1836$ git checkout pull/1836Update a local copy of the PR:
$ git checkout pull/1836$ git pull https://git.openjdk.org/valhalla.git pull/1836/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1836View PR using the GUI difftool:
$ git pr show -t 1836Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1836.diff
Using Webrev
Link to Webrev Comment