8374093: [lworld] Cleanup and polish around vgetfield/vputfield

[jsikstro]

Hello,

I've been looking at the new internal bytecodes vgetfield and vputfield and their callchains from the interpreter down to InlineKlass and have some cleanups. I've not looked at templateTable_x86 so far, only templateTable_aarch64.

Some notes:

• The dest_is_initialized parameter in InlineKlass::write_value_to_addr is true for all callers, so I've removed it and inlined true to the call to copy_payload_to_addr.
• There seems to be an unnecessary mark_payload_as_non_null((address)src); in InlineKlass::copy_payload_to_addr, as the payload should already be non_null if it doesn't match is_payload_marked_as_null in the if-statement just above.

Testing:

• hotspot_valhalla, jdk_valhalla and tier1

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8374093: [lworld] Cleanup and polish around vgetfield/vputfield (Enhancement - P4)

Reviewers

• Frederic Parain (@fparain - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1840/head:pull/1840
$ git checkout pull/1840

Update a local copy of the PR:
$ git checkout pull/1840
$ git pull https://git.openjdk.org/valhalla.git pull/1840/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1840

View PR using the GUI difftool:
$ git pr show -t 1840

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1840.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374093: [lworld] Cleanup and polish around vgetfield/vputfield

Reviewed-by: fparain

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@fparain) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (d34e3efb)
• 01: Full - Incremental (e1f1ffa6)
• 00: Full (8944d003)

[fparain]

LGTM.
Thank you for this cleanup.

[jsikstro]

Merged with the tip of lworld, no conflicts. I also re-ran hotspot_valhalla locally on my aarch64 Mac, which looks good. Thank you for the review @fparain!
/integrate

[openjdk]

@jsikstro
Your change (at version d34e3ef) is now ready to be sponsored by a Committer.

[fparain]

/sponsor

[openjdk]

Going to push as commit b51d2eb.

[openjdk]

@fparain @jsikstro Pushed as commit b51d2eb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.