Removed deprecated DaemonSet rolling update type and legacy template generation #2151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR removes deprecated DaemonSet APIs and modernizes template generation handling to improve future Kubernetes compatibility.
Changes made:
DeprecatedSurgingRollingUpdateTypeconstant fromdaemonset_types.goStandardandInPlaceIfPossible)GenerationfieldBenefits:
Ⅱ. Does this pull request fix one issue?
fixes #2150
Ⅲ. Describe how to verify it
Build verification:
make buildmake testmake lintFunctional verification:
rollingUpdate.type: "Standard"- should work as beforerollingUpdate.type: "InPlaceIfPossible"- should work as beforeGetTemplateGeneration()returns the correct generation valueCode verification:
DeprecatedSurgingRollingUpdateTypeis completely removed from codebase:Ⅳ. Special notes for reviews
StandardorInPlaceIfPossibletypes will continue to work unchangedStandardtype instead ofSurgingFiles to pay special attention to:
apis/apps/v1alpha1/daemonset_types.go- Type definition removalpkg/controller/daemonset/daemonset_update.go- Logic change from annotation to Generation fieldpkg/webhook/daemonset/validating/daemonset_validation.go- Validation logic update