Quality of life tweaks: Enhance motor temp handling in ESC, chill range

[zjwhitehead]

This PR improves telemetry reliability, simplifies alert behavior, and removes dead code.

• Motor temperature validity is now handled explicitly with NaN for disconnected/invalid readings, and downstream logic (monitoring, UI, BLE payloads) treats NaN as “no valid sensor value” instead of generating bad alerts or fake values.
• Sensor monitor behavior was tightened so NaN readings are skipped and alert state is reset cleanly to OK.
• Throttle mapping/control was improved to be mode-aware across the full physical throttle range, with smoother behavior when switching modes and cleaner cruise interaction.
• Critical alert vibration was simplified to a single active path (UI timer + pulse vibration), and the older unused “critical vibration service/task” path was removed.
• Unused helpers and redundant code were removed (including old temp helpers/utilities and unused locals/params), reducing maintenance overhead.
• Altimeter setup API was simplified by removing an unused parameter.

Flown with by Zach, full testing by Paul

[Copilot]

Pull request overview

This pull request enhances motor temperature handling in the ESC telemetry system and refactors throttle mapping to provide mode-aware behavior. The PR addresses issues from testing by @PaulDWhite.

Changes:

• Introduces NaN representation for invalid/disconnected motor temperature sensors instead of range checks
• Implements mode-aware throttle mapping where CHILL mode maps the full physical throttle range to a reduced PWM range (1035-1600) instead of hard clamping
• Adds comprehensive test coverage for new throttle mapping behavior and edge cases

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/sp140/esc.cpp	Updates motor temperature filtering to store NaN for invalid readings instead of keeping previous values
inc/sp140/esc.h	Adds constants and validation function for motor temperature range checking
src/sp140/lvgl/lvgl_updates.cpp	Updates UI to check for NaN motor temperature values instead of range validation
inc/sp140/simple_monitor.h	Enhances sensor monitors to skip NaN values and treat them as OK status
src/sp140/throttle.cpp	Implements potRawToModePwm for mode-aware throttle mapping and updates cruise control to use same mapping
inc/sp140/throttle.h	Documents new mode-aware throttle mapping function
src/sp140/sp140.ino	Updates throttle calls to pass performance mode parameter
src/sp140/ble/esc_service.cpp	Adds comments documenting NaN motor temperature behavior in BLE telemetry
inc/sp140/structs.h	Documents motor_temp field as potentially containing NaN
test/test_throttle/test_throttle.cpp	Adds comprehensive tests for mode-aware throttle mapping, cruise control consistency, and edge cases
test/native_stubs/Arduino.h	Adds test infrastructure for controlling analogRead return values
src/sp140/esc_monitors.cpp	Updates comment to document NaN handling for motor temperature monitor

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.