Skip to content

Feature/ci cd signing#36

Merged
wborn merged 6 commits intomainfrom
feature/ci_cd_signing
Aug 6, 2025
Merged

Feature/ci cd signing#36
wborn merged 6 commits intomainfrom
feature/ci_cd_signing

Conversation

@Miggets7
Copy link
Contributor

@Miggets7 Miggets7 commented Aug 6, 2025

fixes #22

@Miggets7 Miggets7 requested a review from wborn August 6, 2025 10:06
@wborn wborn requested a review from Copilot August 6, 2025 12:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements CI/CD signing improvements as indicated by the title "Feature/ci cd signing" and addresses issue #22. The changes focus on updating the GitHub Actions workflow and refactoring asynchronous code handling in the iOS app.

  • Updates GitHub Actions runner from macos-latest to a specific macos-15 version
  • Refactors async code from deprecated async syntax to modern Task.init
  • Removes specific error handling for invalid URL cases

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/ci_cd.yml Updates macOS runner version for GitHub Actions workflow
GenericApp/GenericApp/UI/WizardDomainViewController.swift Modernizes async syntax and simplifies error handling
Comments suppressed due to low confidence (1)

.github/workflows/ci_cd.yml:27

  • The macOS-15 runner may not be available yet. GitHub Actions typically uses versions like 'macos-13' or 'macos-14'. Verify that 'macos-15' is a valid runner image before deploying this workflow.
    runs-on: macos-15 # is not the macos-latest, which should be by the end of August 2025

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the build succeeding!

@wborn wborn merged commit a1dc1dc into main Aug 6, 2025
1 check passed
@wborn wborn deleted the feature/ci_cd_signing branch August 6, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix signing issue in CI/CD build

2 participants