Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements CI/CD signing improvements as indicated by the title "Feature/ci cd signing" and addresses issue #22. The changes focus on updating the GitHub Actions workflow and refactoring asynchronous code handling in the iOS app.
- Updates GitHub Actions runner from
macos-latestto a specificmacos-15version - Refactors async code from deprecated
asyncsyntax to modernTask.init - Removes specific error handling for invalid URL cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci_cd.yml |
Updates macOS runner version for GitHub Actions workflow |
GenericApp/GenericApp/UI/WizardDomainViewController.swift |
Modernizes async syntax and simplifies error handling |
Comments suppressed due to low confidence (1)
.github/workflows/ci_cd.yml:27
- The macOS-15 runner may not be available yet. GitHub Actions typically uses versions like 'macos-13' or 'macos-14'. Verify that 'macos-15' is a valid runner image before deploying this workflow.
runs-on: macos-15 # is not the macos-latest, which should be by the end of August 2025
wborn
approved these changes
Aug 6, 2025
Member
wborn
left a comment
There was a problem hiding this comment.
Nice to see the build succeeding!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22