Skip to content

CONSOLE-4986: Vendor API changes for GuidedTourFeature capability #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krishagarwal278 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

CONSOLE-4986: Vendor API changes for GuidedTourFeature capability #1091

krishagarwal278 wants to merge 2 commits into from
+4,778 −1,086

Conversation

@krishagarwal278
Copy link
Member

@krishagarwal278 krishagarwal278 commented Jan 12, 2026

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 12, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 12, 2026 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4986 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett January 12, 2026 13:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign therealjon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 12, 2026

/retest

yapei
yapei reviewed Jan 13, 2026
View reviewed changes
manifests/01-operator-config.yaml
Comment on lines +22 to +24
- name: GuidedTour
visibility:
state: Enabled
Copy link
Contributor

@yapei yapei Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add unit tests for the new capability?

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 13, 2026

/retest

@jhadvig
Copy link
Member

jhadvig commented Jan 13, 2026 

level=error msg=Cluster operator monitoring Available is False with UpdatingConsolePluginComponentsFailed: UpdatingConsolePluginComponents: reconciling Console Plugin failed: waiting for ConsolePlugin failed: context deadline exceeded: creating ConsolePlugin object failed: the server could not find the requested resource (post consoleplugins.console.openshift.io)
level=error msg=Cluster operator monitoring Degraded is True with UpdatingConsolePluginComponentsFailed

/retest

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 14, 2026

/retest

1 similar comment
@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 14, 2026

/retest

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 15, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026 •
edited by openshift-ci bot
Loading

@krishagarwal278: This pull request references CONSOLE-4986 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 15, 2026

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jan 15, 2026
@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 15, 2026

/verified later @yanpzhan

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jan 15, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@krishagarwal278: This PR has been marked to be verified later by @yanpzhan.

Details

In response to this:

/verified later @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member

jhadvig commented Jan 15, 2026 •
edited
Loading

@krishagarwal278 please squash the PR into two commits. One for vendoring the changes and one for the actual operator changes.
Also removing the verified label since its QE responsibility to verify our story work.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@jhadvig: The /verified command must be used with one of the following actions: by, later, remove, or bypass. See https://docs.ci.openshift.org/docs/architecture/jira/#premerge-verification for more information.

Details

In response to this:

@krishagarwal278 please squash the PR into two commits. One for vendoring the changes and one for the actual operator changes.
Also removing the verified label since its QE responsibility to verify our story work.

/verified cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig
Copy link
Member

jhadvig commented Jan 15, 2026

/verified remove

@openshift-ci-robot openshift-ci-robot removed verified Signifies that the PR passed pre-merge verification criteria verified-later labels Jan 15, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 15, 2026

@jhadvig: The verified label has been removed.The verified-later label has been removed.

Details

In response to this:

/verified remove

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig jhadvig removed px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jan 15, 2026
@krishagarwal278
GuidedTour Feature implementation
3a4b768 
	modified:   go.mod
	modified:   go.sum
	modified:   manifests/01-operator-config.yaml
	modified:   pkg/console/subresource/consoleserver/config_builder_test.go
	modified:   vendor/github.com/openshift/api/operator/v1/types_console.go
	modified:   vendor/github.com/openshift/api/operator/v1/zz_generated.crd-manifests/0000_50_console_01_consoles.crd.yaml
	modified:   vendor/github.com/openshift/api/operator/v1/zz_generated.swagger_doc_generated.go
	modified:   vendor/modules.txt
@jhadvig
Copy link
Member

jhadvig commented Jan 15, 2026

QE Approver:
/assign @yapei
Docs Approver:
/assign @jseseCCS
PX Approver:
/assign @sferich888

@krishagarwal278
Copy link
Member Author

krishagarwal278 commented Jan 15, 2026

/retest

@sferich888
Copy link

sferich888 commented Jan 15, 2026

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 15, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

@krishagarwal278: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@spadgett spadgett Awaiting requested review from spadgett

1 more reviewer

@yapei yapei yapei left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sferich888 sferich888

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@krishagarwal278 @openshift-ci-robot @jhadvig @sferich888 @yapei