CONSOLE-5015: Refactor file-input to use PF (WIP) #15952
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@logonoff: This pull request references CONSOLE-5015 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/shared
logonoff
force-pushed
the
CONSOLE-5015-file-input
branch
from
b242ead to
4f2d07b
Compare
openshift-ci
bot
added
the
kind/i18n
- Remove `label`, `helpText`, `helpTextInvalid` from `FieldProps` because it's not common to all fields - Remove `hideContents` as a bug previously made this prop not work (we would only hideContents based on if the input file is binary). Now I consider having contents a feature - Rename inputFieldHelpText prop to filenamePlaceholder for PF alignment
logonoff
force-pushed
the
CONSOLE-5015-file-input
branch
from
4f2d07b to
01dbae5
Compare
|
@logonoff: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Remove
label,helpText,helpTextInvalidfromFieldPropsbecause it's not common to all fields