Skip to content

CCXDEV-15589: set limit for gathering interval #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
opokornyy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CCXDEV-15589: set limit for gathering interval #1171

opokornyy wants to merge 2 commits into from

Conversation

@opokornyy
Copy link
Contributor

@opokornyy opokornyy commented Nov 4, 2025

This commit is enforcing min value for the dataReporting interval. The value is set to 10 minutes to avoid overloading processing API with way too many gathering jobs. The config is updated for both configmap and secret.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/config/configobserver/config_test.go
  • pkg/config/configobserver/secretconfigobserver_test.go
  • pkg/config/config_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-15589

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@opokornyy: This pull request references CCXDEV-15589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This commit is enforcing min value for the dataReporting interval. The value is set to 10 minutes to avoid overloading processing API with way too many gathering jobs. The config is updated for both configmap and secret.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/config/configobserver/config_test.go
  • pkg/config/configobserver/secretconfigobserver_test.go
  • pkg/config/config_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-15589

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from BaiyangZhou and ncaak November 4, 2025 09:45
@openshift-ci
Copy link

openshift-ci bot commented Nov 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2025
@opokornyy
Copy link
Contributor Author

opokornyy commented Nov 5, 2025

/retest

8 similar comments
@opokornyy
Copy link
Contributor Author

opokornyy commented Nov 5, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 6, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 7, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Nov 7, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 10, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 13, 2025

/retest

@opokornyy
Copy link
Contributor Author

opokornyy commented Nov 13, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 17, 2025

/retest

ncaak
ncaak reviewed Nov 17, 2025
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@BaiyangZhou
Copy link

BaiyangZhou commented Nov 17, 2025

/retest

2 similar comments
@BaiyangZhou
Copy link

BaiyangZhou commented Nov 18, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 18, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 18, 2025

/test insights-operator-e2e-tests

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 18, 2025

/test e2e-gcp-ovn-techpreview

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 18, 2025

/retest

2 similar comments
@BaiyangZhou
Copy link

BaiyangZhou commented Nov 19, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 19, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 19, 2025

/test insights-operator-e2e-tests

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 20, 2025

/retest

1 similar comment
@opokornyy
Copy link
Contributor Author

opokornyy commented Nov 20, 2025

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 20, 2025

/test e2e-gcp-ovn-techpreview

@BaiyangZhou
Copy link

BaiyangZhou commented Nov 20, 2025

/test insights-operator-e2e-tests

@opokornyy
Copy link
Contributor Author

opokornyy commented Nov 20, 2025

/retest

1 similar comment
@BaiyangZhou
Copy link

BaiyangZhou commented Jan 14, 2026

/retest

@opokornyy
feat: enforce min value for dataReporting interval
bd114ff 
This commit is enforcing min value for the
dataReporting interval. The value is set to 10min
to avoid overloading processing api with way too
many gathering jobs.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy
feat: enforce min value for interval in secrets
1ad137b 
This commit is enforcing minimal value for the
interval in the support secret.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy opokornyy force-pushed the CCXDEV-15589-interval-limit branch from de24a31 to 1ad137b Compare January 14, 2026 13:42
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 14, 2026

New changes are detected. LGTM label has been removed.

@BaiyangZhou
Copy link

BaiyangZhou commented Jan 15, 2026

/test insights-operator-e2e-tests

1 similar comment
@BaiyangZhou
Copy link

BaiyangZhou commented Jan 15, 2026

/test insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

@opokornyy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BaiyangZhou BaiyangZhou Awaiting requested review from BaiyangZhou

1 more reviewer

@ncaak ncaak ncaak left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ncaak ncaak

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@opokornyy @openshift-ci-robot @BaiyangZhou @ncaak