Skip to content

OCPBUGS-65582: set Progressing condition on cluster update #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
opokornyy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

OCPBUGS-65582: set Progressing condition on cluster update #1207

opokornyy wants to merge 1 commit into from

Conversation

@opokornyy
Copy link
Contributor

@opokornyy opokornyy commented Jan 9, 2026

This PR implements functionality to set the Progressing condition of the insights clusteroperator to True when the OpenShift version updates its minor or major version, while ignoring patch version updates.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/controller/status/controller_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

OCPBUGS-65582

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026

@opokornyy: This pull request references Jira Issue OCPBUGS-65582, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR implements functionality to set the Progressing condition of the insights clusteroperator to True when the OpenShift version updates its minor or major version, while ignoring patch version updates.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • None

Documentation

  • None

Unit Tests

  • pkg/controller/status/controller_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

  • None

Breaking Changes

No

References

OCPBUGS-65582

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from BaiyangZhou and ncaak January 9, 2026 10:02
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: opokornyy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2026
@BaiyangZhou
Copy link

BaiyangZhou commented Jan 13, 2026

/test e2e-gcp-ovn-techpreview

@hongkailiu
Copy link
Member

hongkailiu commented Jan 13, 2026

/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@hongkailiu: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b5427640-f05a-11f0-8591-ad49f670dd46-0

@opokornyy opokornyy force-pushed the OCPBUGS-65582-progressing-condition branch from b7d02cf to 481aa64 Compare January 13, 2026 15:11
@opokornyy
feat: set Progressing condition on cluster update
bb4fdc7 
This commit implements functionality to set the
Progressing condition of the insights
clusteroperator to True when the OpenShift version
updates its minor or major version, while ignoring
patch version updates.

Signed-off-by: Ondrej Pokorny <opokorny@redhat.com>
@opokornyy opokornyy force-pushed the OCPBUGS-65582-progressing-condition branch from 481aa64 to bb4fdc7 Compare January 13, 2026 15:17
@opokornyy
Copy link
Contributor Author

opokornyy commented Jan 13, 2026

/retest

@BaiyangZhou
Copy link

BaiyangZhou commented Jan 14, 2026

/test insights-operator-e2e-tests

2 similar comments
@BaiyangZhou
Copy link

BaiyangZhou commented Jan 15, 2026

/test insights-operator-e2e-tests

@BaiyangZhou
Copy link

BaiyangZhou commented Jan 15, 2026

/test insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

@opokornyy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BaiyangZhou BaiyangZhou Awaiting requested review from BaiyangZhou

@ncaak ncaak Awaiting requested review from ncaak

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@opokornyy @openshift-ci-robot @BaiyangZhou @hongkailiu