OCPBUGS-55650: Drop BuildCSIVolumes feature gate logic (Build CSI Volumes in OpenShift Builds is GA since 4.14)

[Moebasim]

This PR removes all logic related to the BuildCSIVolumes feature gate from the openshift-controller-manager.

The BuildCSIVolumesEnabled flag along with its parsing logic, conditional checks, and related test cases has been fully removed. CSI volume support in Build pods is now considered stable and enabled by default, requiring no feature gate.

Originally, the BuildCSIVolumes feature gate was introduced to conditionally enable CSI (Container Storage Interface) volume mounts in Build pods. However, this functionality became generally available (GA) and permanently enabled starting with OpenShift 4.14, rendering the feature gate unnecessary.

As mounting CSI volumes into Build pods is now a standard, fully supported capability, all gate-specific logic is unnecessary and has been cleaned up.

With this change, the BuildCSIVolumes gate is no longer referenced and can also be safely removed from the openshift/api repo.

[openshift-ci-robot]

@Moebasim: This pull request references Jira Issue OCPBUGS-55650, which is invalid:

• expected Jira Issue OCPBUGS-55650 to depend on a bug targeting a version in 4.21.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This PR removes all logic related to the BuildCSIVolumes feature gate from the openshift-controller-manager.

The BuildCSIVolumesEnabled flag along with its parsing logic, conditional checks, and related test cases has been fully removed. CSI volume support in Build pods is now considered stable and enabled by default, requiring no feature gate.

Originally, the BuildCSIVolumes feature gate was introduced to conditionally enable CSI (Container Storage Interface) volume mounts in Build pods. However, this functionality became generally available (GA) and permanently enabled starting with OpenShift 4.14, rendering the feature gate unnecessary.

As mounting CSI volumes into Build pods is now a standard, fully supported capability, all gate-specific logic is unnecessary and has been cleaned up.

With this change, the BuildCSIVolumes gate is no longer referenced and can also be safely removed from the openshift/api repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Moebasim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Moebasim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kunalmemane]

/jira refresh

[openshift-ci-robot]

@kunalmemane: This pull request references Jira Issue OCPBUGS-55650, which is invalid:

• expected Jira Issue OCPBUGS-55650 to depend on a bug targeting a version in 4.21.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@Moebasim: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale