Skip to content

Fix implicitly nullable parameter deprecations #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phpcodemonkey wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Fix implicitly nullable parameter deprecations #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Feature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ public function clear()
* @param array $requestParameters
* @return bool
*/
public function isActive(Rollout $rollout, RolloutUserInterface $user = null, array $requestParameters = array())
public function isActive(Rollout $rollout, ?RolloutUserInterface $user = null, array $requestParameters = array())
{
if (null == $user) {
return $this->isParamInRequestParams($requestParameters)
Expand Down Expand Up @@ -281,7 +281,7 @@ private function isUserInActiveUsers(RolloutUserInterface $user)
* @param RolloutUserInterface|null $user
* @return bool
*/
private function isInActiveGroup(Rollout $rollout, RolloutUserInterface $user = null)
private function isInActiveGroup(Rollout $rollout, ?RolloutUserInterface $user = null)
{
foreach ($this->groups as $group) {
if ($rollout->isActiveInGroup($group, $user)) {
Expand Down
4 changes: 2 additions & 2 deletions src/Rollout.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public function defineGroup($group, \Closure $closure)
* @param array $requestParameters
* @return bool
*/
public function isActive($feature, RolloutUserInterface $user = null, array $requestParameters = array())
public function isActive($feature, ?RolloutUserInterface $user = null, array $requestParameters = array())
{
$feature = $this->get($feature);

Expand Down Expand Up @@ -186,7 +186,7 @@ public function deactivateRequestParam($feature)
* @param RolloutUserInterface|null $user
* @return bool
*/
public function isActiveInGroup($group, RolloutUserInterface $user = null)
public function isActiveInGroup($group, ?RolloutUserInterface $user = null)
{
if (!isset($this->groups[$group])) {
return false;
Expand Down