Open
Conversation
ajkavanagh
suggested changes
Aug 8, 2024
Contributor
ajkavanagh
left a comment
ajkavanagh
left a comment
There was a problem hiding this comment.
I think the entry requires a branches override to limit the releases for the charm to something more recent than bionic-train.
Comment on lines
1000
to
1004
| - name: OpenStack Cinder NFS Charm | ||
| charmhub: cinder-nfs | ||
| launchpad: charm-cinder-nfs | ||
| repository: https://opendev.org/openstack/charm-cinder-nfs.git | ||
|
|
Contributor
There was a problem hiding this comment.
Just to note that this is probably wrong, in that it doesn't include a branches override. It's unlikely that this charm needs to go back to bionic-train. Please select appropriate branches for this charm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.