Open
Conversation
flake8-3.9.2 doesn't run on py312 due to a breaking change in importlib, this change bumps up the pin to 7.1.1 the latest release at the moment. Related-Pr: python/importlib_metadata#409
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Aug 19, 2024
Summary of changes: - Replace self.assertTrue(foo.called) with self.assert_called() - Replace foo.has_calls(...) with foo.assert_has_calls(...) - Fix unit test failures - Bump up flake8 to make it compatible with py312 - Fix flake8/pep8 errors Related-Pr: openstack-charmers/release-tools#301 Change-Id: Id6767e70bfea9fab6a975d8e453d9334f6c31eaa
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 19, 2024
* Update charm-keystone from branch 'master'
to 930f5b31f333f750b6fb7c9ca9f559d60379491e
- Fix unit tests.
Summary of changes:
- Replace self.assertTrue(foo.called) with self.assert_called()
- Replace foo.has_calls(...) with foo.assert_has_calls(...)
- Fix unit test failures
- Bump up flake8 to make it compatible with py312
- Fix flake8/pep8 errors
Related-Pr: openstack-charmers/release-tools#301
Change-Id: Id6767e70bfea9fab6a975d8e453d9334f6c31eaa
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Aug 21, 2024
Summary of changes: - Fix minor formatting error triggered by upgrade from flake8 3.9.2 -> 7.1.1. - Bump flake8 for py312 compatibility (see related-pr) Related-PR: openstack-charmers/release-tools#301 Change-Id: Id0f53ee333833b62078c0f5bedd3e55e63cfd422
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 21, 2024
* Update charm-neutron-api from branch 'master'
to ccfd346a4d40d2cdc24128ff4549399a0d9f1565
- Fix pep8 error
Summary of changes:
- Fix minor formatting error triggered by upgrade from flake8
3.9.2 -> 7.1.1.
- Bump flake8 for py312 compatibility (see related-pr)
Related-PR: openstack-charmers/release-tools#301
Change-Id: Id0f53ee333833b62078c0f5bedd3e55e63cfd422
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Aug 21, 2024
Change-Id: Id5959d121e637d486eab7effd41fc4bc56bd3246 Related-Pr: openstack-charmers/release-tools#301
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 21, 2024
* Update charm-heat from branch 'master'
to b55654fbaa9b56fdb56a080d3e9a2c0e836b3b3a
- Bump up flake8
Change-Id: Id5959d121e637d486eab7effd41fc4bc56bd3246
Related-Pr: openstack-charmers/release-tools#301
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flake8-3.9.2 doesn't run on py312 due to a breaking change in importlib, this change bumps up the pin to 7.1.1 the latest release at the moment.
Related-Pr: python/importlib_metadata#409