Added Keystone restart service test#144
Closed
grebennikov wants to merge 1 commit intoopenstack-charmers:masterfrom
Closed
Added Keystone restart service test#144grebennikov wants to merge 1 commit intoopenstack-charmers:masterfrom
grebennikov wants to merge 1 commit intoopenstack-charmers:masterfrom
Conversation
fnordahl
requested changes
Oct 11, 2018
Collaborator
fnordahl
left a comment
fnordahl
left a comment
There was a problem hiding this comment.
The way the Keystone tests are laid out they already do restart the service multiple times trough config_change of the preferred-api-version.
For OpenStack versions up until Queens the tests consume the effect of that change.
So depending on what you want to accomplish with this test it may or may not be a necessary test to add?
Please see my in-line comments too.
zaza/charm_tests/keystone/tests.py
Outdated
| conf_file, | ||
| set_default, | ||
| set_alternate, | ||
| {'DEFAULT': {'debug': 'True'}}, |
Collaborator
There was a problem hiding this comment.
This should correspond to what you have in the set_default variable
zaza/model.py
Outdated
| :raises: ServiceNotRunning | ||
| """ | ||
| cmd = "stat -c %Y /proc/$(pidof -x {} | cut -f1 -d ' ')".format(service) | ||
| cmd = ("stat -c %Y /proc/$(pgrep {} --nslist pid" |
Collaborator
There was a problem hiding this comment.
This change is not directly connected to you adding a service restart test for the keystone charm. Please split out into separate PR or at least a separate commit.
Contributor
grebennikov
force-pushed
the
filter_pid_in_model_keystone_restart
branch
from
c4cf597 to
76973c1
Compare
Modifies the config of Keystone and makes sure that Apache has been restarted.
grebennikov
force-pushed
the
filter_pid_in_model_keystone_restart
branch
from
76973c1 to
dd81ee9
Compare
Author
|
agreed that the change is not needed |
coreycb
pushed a commit
to coreycb/zaza
that referenced
this pull request
Oct 17, 2023
…ate-units Add get_subordinate_units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also modified PID filtering when restarting service to avoid
watching duplicate PIDs in containers